Skip to content

Fix drawers inconsistencies#176

Merged
mariobalca merged 1 commit intomainfrom
bug/drawers-inconsistencies
Nov 7, 2022
Merged

Fix drawers inconsistencies#176
mariobalca merged 1 commit intomainfrom
bug/drawers-inconsistencies

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Create generic component for drawer component
  • Update all component to use the app-drawer component
  • Uniformize close buttons, drawer behaviour, and actions buttons styling
  • Delete 3 unused components: conversation-form, conversation-list-filter, and conversation-settings
  • Add support to loading icon in dialog component (github integration)
  • Fix buttons styling in merge suggestions page
  • Screenshots (front-end changes only)

Screenshot 2022-11-07 at 11 49 16
Screenshot 2022-11-07 at 11 49 28
Screenshot 2022-11-07 at 11 49 56
Screenshot 2022-11-07 at 11 50 25
Screenshot 2022-11-07 at 11 50 42
Screenshot 2022-11-07 at 11 50 55
Screenshot 2022-11-07 at 11 51 04
Screenshot 2022-11-07 at 11 51 20
Screenshot 2022-11-07 at 11 51 29

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 7, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 6553f7d
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6368f26ed28b2b0009ab5bad

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 7, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 6553f7d
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6368f26e192c090009a9f3a0

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling these 🙌
And once again, thanks for cleaning the codebase and deleting files that are not used anymore 🙏

Will merge, test, and deploy to staging 👍

@mariobalca mariobalca merged commit 016e5da into main Nov 7, 2022
@mariobalca mariobalca deleted the bug/drawers-inconsistencies branch November 7, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants